Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: move circuit breaker to pkg #8932

Merged
merged 2 commits into from
Dec 18, 2024
Merged

client: move circuit breaker to pkg #8932

merged 2 commits into from
Dec 18, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 18, 2024

What problem does this PR solve?

Issue Number: ref #8690, ref #8678

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 18, 2024
@rleungx rleungx requested review from okJiang and JmPotato December 18, 2024 08:50
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-18 08:52:20.328390882 +0000 UTC m=+1033330.417193425: ☑️ agreed by lhy1024.
  • 2024-12-18 08:53:01.728510999 +0000 UTC m=+1033371.817313539: ☑️ agreed by bufferflies.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (bc028fc) to head (b935908).
Report is 1076 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8932      +/-   ##
==========================================
+ Coverage   74.85%   76.29%   +1.43%     
==========================================
  Files         412      461      +49     
  Lines       41991    70305   +28314     
==========================================
+ Hits        31432    53637   +22205     
- Misses       7799    13321    +5522     
- Partials     2760     3347     +587     

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ecb31de into tikv:master Dec 18, 2024
25 checks passed
@rleungx rleungx deleted the move-cb branch December 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants