Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key value tombstone is lost during rewrite #141

Open
tabokie opened this issue Nov 8, 2021 · 0 comments
Open

Key value tombstone is lost during rewrite #141

tabokie opened this issue Nov 8, 2021 · 0 comments
Labels
bug Something isn't working help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tabokie
Copy link
Member

tabokie commented Nov 8, 2021 •
edited
Loading

Bug Report

Description

During Append queue rewrite, key value pairs of targeted Raft groups are scanned out and rewritten to Rewrite queue. After that, data files in Append queue is deleted.

However, in this process, key value tombstones (delete key operation) can't be detected and rewritten. Suppose rewrite is triggered after a Put and before a later Delete, the old key value is stored in Rewrite queue, but the subsequent deletion marker is purged from Append queue. When the engine restarts, the old key value will re-surface.

Right now, TiKV doesn't use kv delete API, so this bug is of minor urgency.
@tabokie tabokie added bug Something isn't working help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 8, 2021
@tabokie tabokie mentioned this issue Nov 9, 2021
Merged
tabokie added a commit that referenced this issue Nov 9, 2021
@tabokie
overhaul engine tests and fix bugs (#143)
b614f96 
Overhaul unit tests for engine. Discover and fix several bugs:

- First rewrite entry could have larger index than first append entry, and causes panic
- Region tombstone in append queue is not applied to rewrite queue during recovery
- [NOT FIXED] State tombstone is lost during rewrite #141
- Rewrite queue log index could jump back, and causes panic
- [NOT FIXED] Recreated region is deleted after rewrite #142

Signed-off-by: tabokie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tabokie