Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul engine tests and fix bugs #143

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Nov 9, 2021

Overhaul unit tests for engine. Discover and fix several bugs:

Signed-off-by: tabokie [email protected]

Signed-off-by: tabokie <[email protected]>
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #143 (2b67ea1) into master (7c2c239) will increase coverage by 0.67%.
The diff coverage is 98.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   96.06%   96.73%   +0.67%     
==========================================
  Files          22       22              
  Lines        5486     5786     +300     
==========================================
+ Hits         5270     5597     +327     
+ Misses        216      189      -27     
Impacted Files Coverage Δ
src/file_builder.rs 100.00% <ø> (ø)
src/test_util.rs 95.00% <85.00%> (-5.00%) ⬇️
src/engine.rs 96.33% <98.36%> (+3.11%) ⬆️
src/file_pipe_log.rs 95.45% <100.00%> (+0.42%) ⬆️
src/log_batch.rs 98.37% <100.00%> (+0.92%) ⬆️
src/memtable.rs 99.49% <100.00%> (+0.73%) ⬆️
src/purge.rs 94.51% <100.00%> (+0.57%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2c239...2b67ea1. Read the comment docs.

Signed-off-by: tabokie <[email protected]>
@tabokie tabokie merged commit b614f96 into tikv:master Nov 9, 2021
@tabokie tabokie deleted the cov-engine branch November 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant