Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide more file writing details from engine #269

Merged
merged 9 commits into from
Sep 6, 2022
Prev Previous commit
Next Next commit
panic on sync
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie committed Sep 5, 2022
commit cc7b94a0b70c8a9d337bfde1b347af6884e37f86
4 changes: 3 additions & 1 deletion src/engine.rs
Original file line number Diff line number Diff line change
@@ -165,7 +165,9 @@ where
}
perf_context!(log_write_duration).observe_since(now);
if sync {
self.pipe_log.sync(LogQueue::Append)?
// As per trait protocol, this error should be retriable. But we panic anyway to
// save the trouble of propagating it to other group members.
self.pipe_log.sync(LogQueue::Append).expect("pipe::sync()");
}
// Pass the perf context diff to all the writers.
let diff = get_perf_context();