[cherry-pick] rewrite: optimize the interval of sync when rewriting memtables. (#347)
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… memtables. (tikv#347) In a cloud environment, refraining from unscheduling sync operations when rewriting memtables might result in an accumulation of unsynced bytes in the buffer. This accumulation has the potential to impede the foreground write progress during sync. This pull request introduces periodic sync operations when the amount of stashed unsynced bytes exceeds a predefined threshold. This optimization aims to address the issue and enhance performance. Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
This reverts commit dfd10fa. Signed-off-by: lucasliang <[email protected]>
This reverts commit 402da7a. Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
overvenus
approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tikv-6.5 #349 +/- ##
============================================
+ Coverage 97.89% 97.95% +0.06%
============================================
Files 31 31
Lines 12228 12239 +11
============================================
+ Hits 11970 11989 +19
+ Misses 258 250 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an manual cherry-pick from #347 .
In a cloud environment, refraining from unscheduling sync operations when rewriting memtables might result in an accumulation of unsynced bytes in the buffer. This accumulation has the potential to impede the foreground write progress during sync.
This pull request introduces periodic sync operations when the amount of stashed unsynced bytes exceeds a predefined threshold. This optimization aims to address the issue and enhance performance.