Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: supply the metric of the compression ratio on write. #358

Merged
merged 12 commits into from
Apr 23, 2024
Merged

engine: supply the metric of the compression ratio on write. #358

merged 12 commits into from
Apr 23, 2024

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Apr 19, 2024 •
edited
Loading

Description

Supply one extra metric to obeserve the compression ratio change of LogBatch when writing.

With this pr, the compression ratio can be reviewed as following shows:
image

Meanwhile, the format of dependencies specified in Cargo.toml is cleared up.

@LykxSassinator
Copy link
Contributor Author

/test

@LykxSassinator
Add change logs.
fdb20c9 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Format ci actions.
d27dea5 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Fix ci errors.
74cd975 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Merge branch 'master' into add_write_compression_ratio
9bf4f64 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish rust.yml.
39238fb 
Signed-off-by: lucasliang <[email protected]>
glorv
glorv reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

src/metrics.rs Show resolved Hide resolved
@LykxSassinator
Copy link
Contributor Author

@glorv Can u help me to merge this pr into master branch ? thx.

@LykxSassinator LykxSassinator requested a review from glorv April 23, 2024 07:03
@glorv glorv merged commit cd1533d into tikv:master Apr 23, 2024
5 checks passed
@LykxSassinator LykxSassinator deleted the add_write_compression_ratio branch April 23, 2024 07:48
@LykxSassinator LykxSassinator mentioned this pull request Apr 23, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LykxSassinator @overvenus @glorv