Merge pull request #277 from tildeio/fix-substates

Fix transition being undefined through substates
tildeio · Jan 9, 2019 · bedbf4e · bedbf4e
2 parents 4b09c3c + fad4cc2
commit bedbf4e
Show file tree

Hide file tree

Showing 2 changed files with 106 additions and 9 deletions.
diff --git a/lib/router/router.ts b/lib/router/router.ts
@@ -227,14 +227,10 @@ export default abstract class Router<T extends Route> {
     }
 
     if (isIntermediate) {
+      let transition = new InternalTransition(this, undefined, undefined);
+      this.toReadOnlyInfos(transition, newState);
       this.setupContexts(newState);
-      let transition = this.activeTransition!;
-      if (transition !== undefined && !transition.isCausedByAbortingTransition) {
-        transition = new InternalTransition(this, undefined, undefined);
-        transition.from = transition.from;
-      }
 
-      this.toInfos(transition, newState.routeInfos);
       this.routeWillChange(transition);
       return this.activeTransition!;
     }
@@ -773,7 +769,7 @@ export default abstract class Router<T extends Route> {
     }
   }
 
-  private toInfos(
+  public toInfos(
     newTransition: OpaqueTransition,
     newRouteInfos: InternalRouteInfo<T>[],
     includeAttributes = false

diff --git a/tests/router_test.ts b/tests/router_test.ts
@@ -1414,7 +1414,7 @@ scenarios.forEach(function(scenario) {
   });
 
   test('abort route events', function(assert) {
-    assert.expect(20);
+    assert.expect(19);
     map(assert, function(match) {
       match('/').to('index');
       match('/posts', function(match) {
@@ -1465,7 +1465,6 @@ scenarios.forEach(function(scenario) {
       } else if (aborted) {
         assert.equal(transition.isAborted, true);
         assert.equal(transition.to, transition.from);
-        assert.equal(transition.to, transition.from);
         assert.equal(transition.to!.localName, 'index');
       } else {
         assert.equal(transition.to!.localName, 'post');
@@ -1501,6 +1500,107 @@ scenarios.forEach(function(scenario) {
       });
   });
 
+  test('always has a transition through the substates', function(assert) {
+    map(assert, function(match) {
+      match('/').to('index');
+      match('/posts', function(match) {
+        match('/:id').to('post');
+        match('/details').to('postDetails');
+      });
+      match('/foo', function(match) {
+        match('/').to('foo', function(match) {
+          match('/bar').to('bar');
+        });
+      });
+      match('/err').to('fooError');
+    });
+
+    let enterSubstate = false;
+    let initial = true;
+    let isAborted = false;
+    let errorHandled = false;
+    let enteredWillChange = 0;
+    let enteredDidChange = 0;
+
+    routes = {
+      post: createHandler('post', {
+        beforeModel(transition: Transition) {
+          isAborted = true;
+          transition.abort();
+          enterSubstate = true;
+          router.intermediateTransitionTo('fooError');
+        },
+      }),
+      foo: createHandler('foo'),
+    };
+
+    router.transitionDidError = (error: TransitionError, transition: Transition) => {
+      if (error.wasAborted || transition.isAborted) {
+        return logAbort(transition);
+      } else {
+        transition.trigger(false, 'error', error.error, transition, error.route);
+        if (errorHandled) {
+          transition.rollback();
+          router.routeDidChange(transition);
+          return transition;
+        } else {
+          transition.abort();
+          return error.error;
+        }
+      }
+    };
+
+    router.routeWillChange = (transition: Transition) => {
+      enteredWillChange++;
+      if (initial) {
+        assert.equal(transition.to!.localName, 'index', 'initial');
+        assert.equal(transition.from!, null, 'initial');
+        assert.equal(transition.to!.parent, null, 'initial');
+      } else if (isAborted) {
+        assert.equal(transition.to!.localName, 'index', 'aborted');
+        assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'aborted');
+      } else if (enterSubstate) {
+        assert.equal(transition.to!.localName, 'fooError', 'substate');
+        assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'substate');
+        assert.equal(transition.to!.parent!.localName, 'foo', 'substate');
+      } else {
+        assert.equal(transition.to!.localName, 'post', 'to post');
+        assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'to post');
+        assert.equal(transition.to!.parent, null, 'to post');
+      }
+    };
+
+    router.routeDidChange = (transition: Transition) => {
+      enteredDidChange++;
+      if (initial) {
+        assert.equal(transition.to!.localName, 'index', 'initial');
+        assert.equal(transition.from!, null, 'initial');
+        initial = false;
+      } else if (isAborted) {
+        assert.equal(transition.to!.localName, 'index', 'aborted');
+        assert.equal(isPresent(transition.from) && transition.from!.localName, 'index', 'aborted');
+        isAborted = false;
+      } else {
+        assert.equal(transition.to!.localName, 'bar');
+        assert.equal(isPresent(transition.from) && transition.from!.localName, 'index');
+      }
+    };
+
+    router
+      .transitionTo('/')
+      .then(() => {
+        return router.transitionTo('/posts/1');
+      })
+      .catch((err: any) => {
+        assert.equal(err.name, 'TransitionAborted');
+        return router.activeTransition as any;
+      })
+      .finally(() => {
+        assert.equal(enteredWillChange, 4);
+        assert.equal(enteredDidChange, 2);
+      });
+  });
+
   test('error route events', function(assert) {
     map(assert, function(match) {
       match('/').to('index');
@@ -1555,6 +1655,7 @@ scenarios.forEach(function(scenario) {
         transition.trigger(false, 'error', error.error, transition, error.route);
         if (errorHandled) {
           transition.rollback();
+          router.toInfos(transition, router.state!.routeInfos, true);
           router.routeDidChange(transition);
           return transition;
         } else {