Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#286 enable test_edit + remove puzzle #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amihaiemil
Copy link
Contributor

PR for #286

  • enabled test_edit from it_table_shapes_test.py
  • removed puzzle

@0crat
Copy link

0crat commented Mar 7, 2019

@amihaiemil/z this pull request is too small, just 5 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @emilianodellacasa/z please review this and merge or reject

@emilianodellacasa
Copy link
Contributor

@amihaiemil There is a problem on Travis, the test you uncommented is failing

@emilianodellacasa
Copy link
Contributor

@amihaiemil ping - the test is still not working, please check travis

@amihaiemil
Copy link
Contributor Author

amihaiemil commented Mar 11, 2019

@emilianodellacasa As I see, the problem with form.save() was not fixed yet, otherwise the test should pass... but what I don't understand: why is there a secont test failing? See here (it's test test_sync_table from it_sync_tables_test.py -- these are different topics, I believe.

@emilianodellacasa
Copy link
Contributor

@amihaiemil Maybe we should wait for #414 , actually you are right it is quite akward that other tests are failing when your code doesn't affect them

@amihaiemil
Copy link
Contributor Author

@emilianodellacasa agree... I'm rather tight on time anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants