Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#366 Location poster mock refactor #540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marceloamadeu
Copy link
Contributor

For #366:

  • Implemented the mock location server based on PosterServerMock implementation.
  • Removed the puzzle.

@0crat 0crat added the scope Issue is in scope label Mar 13, 2019
@0crat
Copy link

0crat commented Mar 13, 2019

Job #540 is now in scope, role is REV

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          55       55           
  Lines        1025     1025           
  Branches       57       57           
=======================================
  Hits          926      926           
  Misses         79       79           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1617f2c...3aaf5f4. Read the comment docs.

@0crat
Copy link

0crat commented Mar 13, 2019

Job gh:timelesslounge/timelessis#540 already assigned to @vryazanov, can't assign to @vryazanov

@0crat
Copy link

0crat commented Mar 13, 2019

This pull request #540 is assigned to @vryazanov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@vryazanov
Copy link
Contributor

@0crat refuse

@0crat
Copy link

0crat commented Mar 15, 2019

@0crat refuse (here)

@vryazanov The user @vryazanov/z resigned from #540, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Mar 15, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @vryazanov/z

@0crat
Copy link

0crat commented Apr 5, 2019

This pull request #540 is assigned to @vladarefiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@vladarefiev
Copy link

@0crat refuse

@0crat
Copy link

0crat commented Apr 11, 2019

@0crat refuse (here)

@vladarefiev The user @vladarefiev/z resigned from #540, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Apr 11, 2019

@vladarefiev/z I see that you unassigned this issue; the order is still assigned to @vladarefiev/z though; to cancel the order use refuse, as in §6

@0crat
Copy link

0crat commented Apr 11, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @vladarefiev/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope Issue is in scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants