Skip PostgreSQL 12 by default for CICD #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feikesteenbergen
force-pushed
the
feike/remove_pg12
branch
from
18b7d60 to
f85345a
Compare
TimescaleDB 2.13.0 does not support PostgreSQL 12 anymore. This currently causes our CI to fail. To still be able to test PostgreSQL 12, we will run it if the TimescaleDB tag is set to 2.11.2 https://docs.timescale.com/about/latest/release-notes/#timescaledb-2120-on-2023-09-27
feikesteenbergen
force-pushed
the
feike/remove_pg12
branch
from
f85345a to
c8a3c56
Compare
svenklemm
approved these changes
Nov 27, 2023
feikesteenbergen
force-pushed
the
feike/remove_pg12
branch
3 times, most recently
from
926aade to
7724048
Compare
|
Dev build images have been built by this github action |
Previously, we depended on the value of PG_VERSIONS or TSDB_PG_VERSIONS.
This doesn't always work correctly, however, we can switch to
determining the versions at runtime, that should prevent errors like:
528.1 + for pg in '$PG_VERSIONS'
528.1 + init_flags=' --pg12 /usr/pgsql-12/bin/pg_config --pg13 /usr/pgsql-13/bin/pg_config --pg14 /usr/pgsql-14/bin/pg_config --pg15 /usr/pgsql-15/bin/pg_config --pg16 /usr/pgsql-16/bin/pg_config'
528.1 + cargo pgrx init --pg12 /usr/pgsql-12/bin/pg_config --pg13 /usr/pgsql-13/bin/pg_config --pg14 /usr/pgsql-14/bin/pg_config --pg15 /usr/pgsql-15/bin/pg_config --pg16 /usr/pgsql-16/bin/pg_config
528.1 Creating PGRX_HOME at `/home/postgres/.pgrx`
528.1 The application panicked (crashed).
528.1 Message: no major version:
528.1 0: The specified pg_config binary, `/usr/pgsql-16/bin/pg_config`, does not exist
528.1 1: No such file or directory (os error 2)
feikesteenbergen
force-pushed
the
feike/remove_pg12
branch
from
7724048 to
67ec93c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimescaleDB 2.12.0 does not support PostgreSQL 12 anymore. This currently causes our CI to fail. To still be able to test PostgreSQL 12, we will run tests against TimescaleDB 2.11.2 for PostgreSQL 12, and for Debian only.
https://docs.timescale.com/about/latest/release-notes/#timescaledb-2120-on-2023-09-27