Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Pricing Compare Box #2561

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Fixes to Pricing Compare Box #2561

merged 4 commits into from
Nov 29, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Nov 29, 2024 •
edited
Loading

There were numerous small issues addressed in this PR - as per #2543

Changes

  • Add isReccomended boolean to the column titles so we can identify a reccomended tier
  • Fixed the background color of hovered rows in synch with scrolling-x
  • Fixed width of 1st column so we have a uniform column sizinf
  • Fixed copy inside table, made all capitalisation uniform

@joshbermanssw joshbermanssw requested a review from a team as a code owner November 29, 2024 06:16
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 6:22am

@joshbermanssw joshbermanssw enabled auto-merge (squash) November 29, 2024 06:25
@joshbermanssw joshbermanssw merged commit 22fab29 into main Nov 29, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the improve-pricing-compare-table branch November 29, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaclombardssw isaaclombardssw isaaclombardssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshbermanssw @isaaclombardssw