chore: update to Nx workspace v18.3.4

package.json

@@ -7,11 +7,11 @@
     "build": "nx run-many --target build --parallel 4 --exclude smoke",
     "test": "nx run-many --target test --parallel 4 --exclude smoke --runInBand",
     "e2e": "ts-node -P ./tools/tsconfig.tools.json ./tools/scripts/run-all-e2e-tests.ts",
-    "lint": "nx run-many --target=lint --fix --parallel 4 --exclude smoke",
+    "lint": "nx run-many --target lint --fix --parallel 4 --exclude smoke",
     "affected:build": "nx affected --target build --exclude=smoke",
     "affected:e2e": "nx affected --target e2e --exclude=smoke",
     "affected:test": "nx affected --target test --exclude=smoke",
-    "affected:lint": "nx affected --target lint",
+    "affected:lint": "nx affected --target lint --fix",
     "affected:graph": "nx affected --graph",
     "affected:format": "nx affected --target format --exclude=smoke",
     "format": "nx format:write",
@@ -49,13 +49,13 @@
     "@commitlint/cli": "^17.6.1",
     "@commitlint/config-angular": "^17.6.1",
     "@jest/globals": "^29.5.0",
-    "@nx/devkit": "18.1.3",
-    "@nx/eslint-plugin": "18.1.3",
-    "@nx/jest": "18.1.3",
-    "@nx/js": "18.1.3",
-    "@nx/node": "18.1.3",
-    "@nx/plugin": "18.1.3",
-    "@nx/workspace": "18.1.3",
+    "@nx/devkit": "18.3.4",
+    "@nx/eslint-plugin": "18.3.4",
+    "@nx/jest": "18.3.4",
+    "@nx/js": "18.3.4",
+    "@nx/node": "18.3.4",
+    "@nx/plugin": "18.3.4",
+    "@nx/workspace": "18.3.4",
     "@swc-node/register": "1.8.0",
     "@swc/cli": "0.1.62",
     "@swc/core": "1.3.87",
@@ -68,23 +68,21 @@
     "@types/unzipper": "^0.10.5",
     "@types/xmldoc": "^1.1.6",
     "@types/yargs": "^17.0.26",
-    "@typescript-eslint/eslint-plugin": "^5.60.1",
-    "@typescript-eslint/parser": "^5.60.1",
+    "@typescript-eslint/eslint-plugin": "^7.3.0",
+    "@typescript-eslint/parser": "^7.3.0",
     "dotenv": "10.0.0",
-    "eslint": "~8.15.0",
-    "eslint-config-prettier": "8.1.0",
+    "eslint": "~8.57.0",
+    "eslint-config-prettier": "^9.0.0",
     "fs-extra": "^10.1.0",
     "husky": "^8.0.3",
     "jest": "29.4.3",
     "jest-environment-jsdom": "29.4.3",
     "jest-environment-node": "^29.4.1",
     "jest-mock": "28.1.3",
-    "jsonc-eslint-parser": "^2.2.0",
-    "nx": "18.1.3",
+    "nx": "18.3.4",
     "prettier": "2.6.2",
     "ts-jest": "29.1.0",
     "ts-node": "10.9.1",
-    "tslint": "6.1.3",
     "typescript": "5.3.3",
     "verdaccio": "^5.0.4"
   },

packages/nx-melos/src/generators/init/generator.spec.ts

@@ -6,8 +6,6 @@ import { InitGeneratorOptions } from './schema';
 
 jest.mock('child_process'); // we need to mock 'execSync' so that it doesn't really run 'melos' (reserved to e2e testing) (see __mocks__/child_process.js)
 
-import { NX_MELOS_PKG } from '../../index';
-
 describe('init generator', () => {
   let tree: Tree;
   const options: InitGeneratorOptions = {};

packages/nx-melos/src/generators/init/schema.d.ts

@@ -1,4 +1,3 @@
-
 export interface InitGeneratorOptions {
-  scriptNameSeparator?: '-' | ':' = '-';
+  scriptNameSeparator?: '-' | ':';
 }