Skip to content

Commit

Permalink
fix: do not generate targets at parent module level and lets Nx man…
Browse files Browse the repository at this point in the history
…age dependencies entirely

BREAKING CHANGE: `project.json` of parent module no longer contain `targets`

This caused conflicts, when for e.g , running a task `build` from the parent module. `Maven`/`Gradle` would trigger the build on child modules, when Nx already did using project graph.
  • Loading branch information
tinesoft committed Feb 23, 2024
1 parent e210406 commit e9e8e1c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export async function generateProjectConfiguration(
root: options.moduleRoot,
sourceRoot: `${options.moduleRoot}`,
projectType: 'application',
targets: getTargets(parentModuleCommands, options.moduleRoot, false),
targets: {},
tags: options.parsedTags,
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function generateProjectConfiguration(
root: options.moduleRoot,
sourceRoot: `${options.moduleRoot}`,
projectType: 'application',
targets: getTargets(parentModuleCommands, options.moduleRoot, false),
targets: {},
tags: options.parsedTags,
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export async function generateProjectConfiguration(
root: options.moduleRoot,
sourceRoot: `${options.moduleRoot}`,
projectType: options.projectType,
targets: getTargets(parentModuleCommands, options.moduleRoot, false),
targets: {},
tags: options.parsedTags,
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function generateProjectConfiguration(
root: options.moduleRoot,
sourceRoot: `${options.moduleRoot}`,
projectType: options.projectType,
targets: getTargets(parentModuleCommands, options.moduleRoot, false),
targets: {},
tags: options.parsedTags,
});
}
Expand Down

0 comments on commit e9e8e1c

Please sign in to comment.