fix(nx-quarkus): support javaVersion argument override for nx-quarkus package #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to address a project generator validation error on the
javaVersion
argument. Currently when passingjavaVersion
as an argument you get the error message "Property 'javaVersion' does not match the schema. '17' should be a 'string'.".This worked when I was on version
8.0.1
of the nx-quarkus plugin, but after upgrading to the latest I started seeing this error.I couldn't get the dev container setup to work to run the e2e tests and validate the behavior fully.
A couple issues/fixes I saw that seemed relevant that I used to model this change after:
I'd love to be able to get the dev container setup working to be able to contribute to this project more regularly. I'm looking to use it in some critical projects, I may just need a little help/guidance troubleshooting my devcontainer issue. I'm able to run the regular tests, but the verdaccio connection times out when running the e2e tests.