Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-quarkus): support javaVersion argument override for nx-quarkus package #229

Conversation

Cameron-C-Chapman
Copy link
Contributor

@Cameron-C-Chapman Cameron-C-Chapman commented Jul 13, 2024

This tries to address a project generator validation error on the javaVersion argument. Currently when passing javaVersion as an argument you get the error message "Property 'javaVersion' does not match the schema. '17' should be a 'string'.".

This worked when I was on version 8.0.1 of the nx-quarkus plugin, but after upgrading to the latest I started seeing this error.

I couldn't get the dev container setup to work to run the e2e tests and validate the behavior fully.

A couple issues/fixes I saw that seemed relevant that I used to model this change after:

I'd love to be able to get the dev container setup working to be able to contribute to this project more regularly. I'm looking to use it in some critical projects, I may just need a little help/guidance troubleshooting my devcontainer issue. I'm able to run the regular tests, but the verdaccio connection times out when running the e2e tests.

… package

This tries to address a project generator validation error on the `javaVersion` argument. Currently when passing `javaVersion` as an argument you get the error message "Property 'javaVersion' does not match the schema. '17' should be a 'string'.".
Copy link

nx-cloud bot commented Jul 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1fd4752. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@tinesoft
Copy link
Owner

HI @Cameron-C-Chapman

Thank you for spotting the issue and for your pull request, much appreciated.

I'll gladly help you with the issue you're having with the dev container. Let me know more about it (here or via DM)
As for the running the e2e test locally, there do take time indeed (I still need to improve that), but nonetheless you can still
create PRs, and let the CI perform all the e2e tests.

@tinesoft tinesoft closed this Jul 14, 2024
@tinesoft tinesoft reopened this Jul 14, 2024
@tinesoft tinesoft merged commit dcd4e37 into tinesoft:develop Jul 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants