Update to use image-builder based images #51
Conversation
…rl, os, os version
detiber
changed the title
| @@ -166,7 +166,7 @@ KUSTOMIZE_VER := v3.9.2 | |||
| KUSTOMIZE_BIN := kustomize | |||
| KUSTOMIZE := $(TOOLS_BIN_DIR)/$(KUSTOMIZE_BIN)-$(KUSTOMIZE_VER) | |||
|
|
|||
| CONTROLLER_GEN_VER := v0.4.1 | |||
| CONTROLLER_GEN_VER := v0.2.9 | |||
There was a problem hiding this comment.
This aligns more closely with CAPI v1alpha3
| bootstrapped. | ||
| As it is now it is able to bootstrap single Control Plane instance clusters using hardware | ||
| managed by Tinkerbell. Support for upgrades and multi-instance Control Plane clusters is | ||
| still outstanding. |
There was a problem hiding this comment.
Updated to be more reflective of the current state of the project, and link to the development environment docs
There was a problem hiding this comment.
Is it worth mentioning what people should expect from v0.1.0?
There was a problem hiding this comment.
I was mostly planning on doing the release after getting this PR sorted out, which would allow for cleaning up some of the current docs around creating a template and deploying.
I think the HA support is likely to be a bit of a longer tail and may be easier to implement along with CAPI v1alpha4 (assuming the load balancer provider proposal makes it in)
| @@ -6,18 +6,21 @@ If you have Tinkerbell running in your environment, you can use it for CAPT. | |||
|
|
|||
| Here is the list of required components to use CAPT: | |||
|
|
|||
| - Existing Tinkerbell installation running at least versions mentioned in [sandbox](https://github.com/tinkerbell/sandbox/commit/be40a7b371fdab947a413e190cfe99b692651d8e). | |||
There was a problem hiding this comment.
Documentation updates to reflect changes needed to run image-builder based configuration
| k8s.io/api v0.17.16 | ||
| k8s.io/apimachinery v0.17.16 | ||
| k8s.io/client-go v0.17.16 | ||
| k8s.io/klog v1.0.0 | ||
| k8s.io/utils v0.0.0-20201110183641-67b214c5f920 | ||
| sigs.k8s.io/cluster-api v0.3.14 | ||
| sigs.k8s.io/cluster-api v0.3.15 |
There was a problem hiding this comment.
These bumps incorporate the changes from the automated dependabot PRs, I was able to do an end-to-end test to verify that they didn't break anything.
| - `git` binary | ||
| - `tilt` binary | ||
| - `kubectl` binary | ||
| - `clusterctl` binary | ||
| - `go` binary | ||
|
|
||
| Required metadata for hardware: |
There was a problem hiding this comment.
Can we specify why those fields are mandatory?
There was a problem hiding this comment.
I created #56 to follow up on this
| - metadata.instance.id is set (should match the hardware's id) | ||
| - metadata.instance.hostname is set | ||
| - metadata.instance.storage.disks is set and contains at least one device matching an available disk on the system | ||
|
|
||
| ### Workaround for 8000 bytes template limit |
There was a problem hiding this comment.
This can be removed since we removed events from tink-server tinkerbell/tink#468
There was a problem hiding this comment.
Yeah, was planning on updating the docs (and implementation) to reflect that once there is a sandbox release that includes that PR
Description
Update cluster-api-provider-tinkerbell to use image-builder based images rather than trying to bootstrap everything at runtime.
How Has This Been Tested?
Testing is ongoing