Add test for discoverTrustedProxies

Signed-off-by: Jacob Weinstock <[email protected]>

cmd/smee/backend.go

@@ -107,7 +107,7 @@ func (k *Kube) discoverTrustedProxies(ctx context.Context, l logr.Logger, truste
 // For example, if a cluster has 3 nodes, each with a /24 podCIDR, and the cluster has a /16 podCIDR, combinedCIDRs will return 4 CIDR ranges.
 func combinedCIDRs(ctx context.Context, l logr.Logger, c corev1client.CoreV1Interface, trustedProxies []string) []string {
 	var tp []string
-	copy(tp, trustedProxies)
+	tp = append(tp, trustedProxies...)
 	if podCIDRS, err := perNodePodCIDRs(ctx, c); err == nil {
 		tp = append(tp, podCIDRS...)
 	} else {

cmd/smee/backend_test.go

@@ -182,3 +182,69 @@ func TestCombinedCIDRs(t *testing.T) {
 		})
 	}
 }
+
+func TestDiscoverTrustedProxies(t *testing.T) {
+	tests := map[string]struct {
+		spec []runtime.Object
+		want []string
+	}{
+		"no podCIDR": {},
+		"podCIDR": {
+			spec: []runtime.Object{
+				&v1.NodeList{
+					Items: []v1.Node{
+						{
+							ObjectMeta: metav1.ObjectMeta{
+								Name: "node1",
+							},
+							Spec: v1.NodeSpec{
+								PodCIDRs: []string{"10.42.0.0/24"},
+							},
+						},
+						{
+							ObjectMeta: metav1.ObjectMeta{
+								Name: "node2",
+							},
+							Spec: v1.NodeSpec{
+								PodCIDRs: []string{"10.42.1.0/24"},
+							},
+						},
+					},
+				},
+				&v1.PodList{
+					Items: []v1.Pod{
+						{
+							ObjectMeta: metav1.ObjectMeta{
+								Labels: map[string]string{
+									"component": "kube-controller-manager",
+								},
+								Namespace: "kube-system",
+							},
+							Spec: v1.PodSpec{
+								Containers: []v1.Container{
+									{
+										Command: []string{
+											"kube-controller-manager",
+											"--allocate-node-cidrs=true",
+											"--authentication-kubeconfig=/etc/kubernetes/controller-manager.conf",
+										},
+									},
+								},
+							},
+						},
+					},
+				},
+			},
+			want: []string{"10.42.1.0/24", "10.42.0.0/24"},
+		},
+	}
+	for name, test := range tests {
+		t.Run(name, func(t *testing.T) {
+			k := &Kube{}
+			got := k.discoverTrustedProxies(context.Background(), logr.Discard(), nil)
+			if diff := cmp.Diff(got, test.want); diff != "" {
+				t.Fatalf("unexpected result (+want -got):\n%s", diff)
+			}
+		})
+	}
+}