New dhcp lib #326
Closed
New dhcp lib #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
the
do-not-merge
jacobweinstock
force-pushed
the
new-dhcp-lib
branch
from
dde75e9
to
446ce49
Compare
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
====================================
+ Coverage 18% 68% +50%
====================================
Files 17 5 -12
Lines 1073 229 -844
====================================
- Hits 197 157 -40
+ Misses 862 58 -804
Partials 14 14
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
Signed-off-by: Jacob Weinstock <[email protected]>
The dhcp4-go and pkg libraries are old and unmaintained. Code is refactored and organized around 4 functions. 1. iPXE binary serving (tftp and http) 2. iPXE script serving (http) 3. dhcp service (udp) 4. syslog service (udp) Signed-off-by: Jacob Weinstock <[email protected]>
We are only serving the auto.ipxe at / so it is now explicitly being served at /auto.ipxe. This enables iPXE binaries to be served at / and we can entirely remove the prefix. Also, added the ability to disable syslog and dhcp services. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
new-dhcp-lib
branch
from
446ce49
to
b44a0ad
Compare
New version removes the use of netaddr library. netaddr is deprecated and causes issues. Signed-off-by: Jacob Weinstock <[email protected]>
Use github.com/tinkerbell/dhcp backends. Signed-off-by: Jacob Weinstock <[email protected]>
Also, add some ipxe script tests. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Upgrade dependencies. Remove pkg/errors dep as the repo has been archived. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
new-dhcp-lib
branch
4 times, most recently
from
8d04de7
to
3adc07c
Compare
The default size of /run/user/1001 is about 1.4G. Boots needs more. I don't why Boots needs more than this. Will investigate. This workarounds the failed builds for now. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
new-dhcp-lib
branch
from
a1e579d
to
3211b17
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
|
redundant with #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why is this needed
Fixes: #266
Fixes: #195
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: