Remove kernel parameter ip=dhcp: #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a machine had multiple interfaces that weren't all plugged in, this would cause significant delay in booting into Hook. If necessary, this value can be added back in via the `-extra-kernel-args` cli flag. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
===================================
Coverage 13% 13%
===================================
Files 18 18
Lines 1732 1732
===================================
Hits 233 233
Misses 1482 1482
Partials 17 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is an improved DHCP library. The package layout has been updated to improve the reflection of the services that Boots runs. The `cmd/boots` package has been remove and main.go is not top level. The extra packages are necessary. References to `cmd/boots` were removed. test directory and docker-compose were updated to work with these changes. The cli flags and env vars have been updated and reorganized by function (syslog, dhcp, tftp, http ipxe binaries, http ipxe scripts). This helps func main be to more understandable. The phonehome endpoint and all `/_packet` were removed. These were old deprecated endponts that don't serve much purpose now. The syslog package was updated to handle shutdown via context, so that it can be used like the other services with `errgroup`. Update nix shell file to use Go 1.20. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
There isn't a strong enough case for the backend code to have its own package. Signed-off-by: Jacob Weinstock <[email protected]>
This enables honoring the `http-ipxe-binary-enabled` and `http-ipxe-script-enabled` if they both are disabled. Signed-off-by: Jacob Weinstock <[email protected]>
This sorts the flags in the usage output by the service name in between the brackets "[]" in the usage string. Signed-off-by: Jacob Weinstock <[email protected]>
Clarify Boots interoperability with existing DHCP servers. Update flag and env var references. Add section on the services Boots provides. Signed-off-by: Jacob Weinstock <[email protected]>
Order by service name in the "[]" and the flag name. Signed-off-by: Jacob Weinstock <[email protected]>
This helps clarify data translation between the handler.BackendReader and script.Data. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
HandlerMapping type in the http package allows func main to not need the stdlib http package and thus allowing bhttp to be http. Signed-off-by: Jacob Weinstock <[email protected]>
Simpler use of go run makes it easier to understand and lessens the make fu needed. Signed-off-by: Jacob Weinstock <[email protected]>
Improve clarity of purpose. Signed-off-by: Jacob Weinstock <[email protected]>
The previous version was doing what goimports was already doing. Signed-off-by: Jacob Weinstock <[email protected]>
While i prefer single command main funcs to live top level, the top level has a lot of files aleady and it felt more difficult to see and understand the Go files when they lived at the top level. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This was in main package but didnt make sense being there. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Also fixed some typos. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a machine had multiple interfaces that weren't all plugged in, this would cause significant delay in booting into Hook.
If necessary, this value can be added back in via the
-extra-kernel-argscli flag.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: