Update dependencies #344
Merged
Update dependencies #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version provides improved logging and simpilfied server functions and methods. Signed-off-by: Jacob Weinstock <[email protected]>
|
Hey @chrisdoherty4, mind checking this one out when you have some cycles? |
cmd/smee/main.go
Outdated
Comment on lines
226
to
228
| defer func() { | ||
| _ = conn.Close() | ||
| }() |
There was a problem hiding this comment.
Does this throw a linter error when defering conn.Close() directly? If so, can we just use //nolint: ...?
There was a problem hiding this comment.
its does. sure thing, will update.
There was a problem hiding this comment.
hmmm....actually i dont think the linting will complain. i must have just done it assuming the linter would complain. regardless, i've updated it.
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
We were asking for an IP but showing a URL. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
update-dhcp-lib
branch
from
ade62d2
to
c45204d
Compare
|
Hey @chrisdoherty4. Sorry, couple minor updates to this one since you last reviewed. Thanks! |
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version provides improved logging and simplified server functions and methods. Also update all direct and transitive deps and add a dependabot config.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: