Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on DHCP handler interface: #557

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jacobweinstock
Copy link
Member

Description

The DHCP handler interface has a method we don't need and didn't need to be a dependency of this package. Also, did some code reorganization and added some code comments.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The DHCP handler interface has a method we don't
need and didn't need to be a dependency of this
package. Also, did some code reorganization and
added some code comments.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 50%. Comparing base (543920a) to head (0abe379).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/iso/iso.go 25% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #557   +/-   ##
===================================
- Coverage    50%    50%   -1%     
===================================
  Files        27     27           
  Lines      2975   2976    +1     
===================================
- Hits       1502   1500    -2     
- Misses     1421   1423    +2     
- Partials     52     53    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jacobweinstock jacobweinstock merged commit 108bffc into tinkerbell:main Nov 21, 2024
4 of 5 checks passed
@jacobweinstock jacobweinstock deleted the update branch November 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant