Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forRoot #27

Merged
merged 5 commits into from
Aug 13, 2023
Merged

feat: forRoot #27

merged 5 commits into from
Aug 13, 2023

Conversation

player31-kks
Copy link
Collaborator

@player31-kks player31-kks commented Aug 13, 2023

Description

Add importSync

I created a synchronous file reading function to create forRoot function.

  • create forRoot function
  • create ImporSync class

Troubleshooting when introducing other dependencies.

Module({
      ...originalMetadata,
      imports: [...originalMetadata.imports],
      controllers: [...originalMetadata.controllers, ...(module.controllers ?? [])],
      providers: [...originalMetadata.providers, ...(module.providers ?? [])],
    })(target);
  };

I imported the origin module as it is, and put the remaining autoInjectable and autoController in the origin module

References

no References

Checklist

  • Add labels and reviewers ?
  • Are you fully explaining what you changed ?
  • Did you check that there is no conflict with the base branch ?

@player31-kks player31-kks requested a review from Nhahan August 13, 2023 12:58
@Nhahan Nhahan added the enhancement New feature or request label Aug 13, 2023
@Nhahan Nhahan changed the title Feature/forroot feat: forRoot Aug 13, 2023
@Nhahan
Copy link
Member

Nhahan commented Aug 13, 2023

This PR will mark a magnificent step for our project. 😆

lib/auto.module.ts Outdated Show resolved Hide resolved
lib/auto.module.ts Show resolved Hide resolved
lib/core/importSync.ts Outdated Show resolved Hide resolved
lib/core/importSync.ts Outdated Show resolved Hide resolved
lib/core/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@Nhahan Nhahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Best PR ever. really.

@Nhahan Nhahan merged commit 2db0023 into dev Aug 13, 2023
@Nhahan Nhahan deleted the feature/forroot branch August 13, 2023 15:14
@Nhahan Nhahan mentioned this pull request Aug 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants