Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @AutoAlias() #31

Merged
merged 9 commits into from
Aug 16, 2023
Merged

feat: @AutoAlias() #31

merged 9 commits into from
Aug 16, 2023

Conversation

Nhahan
Copy link
Member

@Nhahan Nhahan commented Aug 15, 2023

Description

  • merge import-sync.ts into importer.ts
  • @AutoAlias() for injectable classes that have @AutoInjectable() to defined alias. Check the below usage code block.
@AutoAlias('Cat')
@AutoInjectable()
export class CatService {
  // ...
}
@AutoController()
export class CatController {
  constructor(@Inject('Cat') private readonly catService: CatService) {}

  @Get('cats')
  getCats() {
    return this.catService.findAll();
  }
}

Checklist

  • Add labels and reviewers ?
  • Are you fully explaining what you changed ?
  • Did you check that there is no conflict with the base branch ?

@Nhahan Nhahan added enhancement New feature or request in progress in progress labels Aug 15, 2023
@Nhahan Nhahan requested a review from player31-kks August 15, 2023 11:34
@Nhahan Nhahan self-assigned this Aug 15, 2023
@player31-kks
Copy link
Collaborator

Can you add AutoAlias to the description?

@Nhahan
Copy link
Member Author

Nhahan commented Aug 15, 2023

Can you add AutoAlias to the description?

I added in progress label for in progress PR. I didn't add the description of it because it was still in progress. 🥲
As it's now finished, I will. 😄

@Nhahan Nhahan removed the in progress in progress label Aug 15, 2023
@Nhahan Nhahan requested a review from player31-kks August 16, 2023 13:11
@Nhahan Nhahan merged commit 8c64292 into dev Aug 16, 2023
@Nhahan Nhahan deleted the feat/auto-alias branch August 16, 2023 13:12
@Nhahan Nhahan mentioned this pull request Aug 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants