fix: issue#44 more Nest like error
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Nhahan
commented
Sep 6, 2023
| `ComponentScan() module scope cannot be overlapped.\n\nPotential causes:\n- An overlapped dependency between modules.\n- Please check the module in '${this.rootPath}' and '${path}'\n\nScope [${value.name}]`, | ||
| `ComponentScan() module scope cannot be overlapped.\n\nPotential causes:\n- An overlapped dependency between modules.\n- Please check the module in '${ | ||
| this.rootPath | ||
| }' and '${path}'\n\nScope [${value.name} -> ${this.classMap.get(this.rootPath)!.name}]`, |
There was a problem hiding this comment.
I know some people may dislike ! syntax. But in this case, this.rootPath key is definetely defined, so I used it to make the code short and clear.
Looks fine to me, but if you have a different opinion please let me know. 😄
player31-kks
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Define
classMapto handle classes and paths that are scanned by theImporterclass.Then, check for any overlapping classes in the
classMapand display them to the users.Please check the image below.
References
Nestlike error #44Checklist