Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-3308: Overriden props are now typed as an internal DoNotUse type #527

Merged
merged 2 commits into from
May 20, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented May 17, 2024

INT-3308

The previous props that were typed as never, are now typed as DoNotUse<message>. So when one of these props are assigned to, e.g.

<Editor
  init={{ selector: 'textarea' }}
/>

It will cause a TS error like this:

error TS2322: Type 'string' is not assignable to type 'DoNotUse<"selector prop is handled internally by the component">'.

@danoaky-tiny danoaky-tiny requested a review from a team as a code owner May 17, 2024 00:12
@danoaky-tiny danoaky-tiny requested review from spocke, TheSpyder and vpyshnenko and removed request for a team May 17, 2024 00:12
@danoaky-tiny danoaky-tiny changed the title INT-3308: Overriden props are INT-3308: Overriden props are now type as an internal DoNotUse type May 17, 2024
@danoaky-tiny danoaky-tiny changed the title INT-3308: Overriden props are now type as an internal DoNotUse type INT-3308: Overriden props are now typed as an internal DoNotUse type May 17, 2024
@danoaky-tiny danoaky-tiny merged commit d822088 into main May 20, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3308 branch May 20, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants