Add middleman 4.4 support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something around these parts are going to break with Middleman 4.4 - let's see if we can pinpoint it.
Without this `site_data` ends up returning `nil` on Middleman 4.4. `data` from Middleman returns a `Middleman::CoreExtensions::Data::DataStore`, and `data['site']` returns a `Middleman::Util::EnhancedHash`. That is all fine. However, we then end up calling `with_indifferent_access` on the `EnhancedHash`, which hits `EnhancedHash#method_missing` because `with_indifferent_access` isn't defined. That `method_missing` call then returns `nil` which is what `site_data` ends up returning, breaking all subsequent `[]` accesses.
|
Thanks a lot @koppen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this
site_dataends up returningnilon Middleman 4.4.datafrom Middleman returns aMiddleman::CoreExtensions::Data::DataStore, anddata['site']returns aMiddleman::Util::EnhancedHash. That is all fine.However, we then end up calling
with_indifferent_accesson theEnhancedHash, which hitsEnhancedHash#method_missingbecausewith_indifferent_accessisn't defined. Thatmethod_missingcall thenreturns
nilwhich is whatsite_dataends up returning, breaking all subsequent[]accesses.I am guessing Middleman 4.4 stopped requiring
"active_support/core_ext/hash/indifferent_access"and we've relied on that until now, although I haven't been able to verify that.This fixes #25, #26 as far as I can tell.