Add support for Static and Streaming SSR #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add static sir support * Postinstall git support * Build only * Enabled src files * Bug fix buildselector * Babel post install bug * Fixed build selector * Fix strings * Update react head
zhangciwu
pushed a commit
to zhangciwu/react-head
that referenced
this pull request
Aug 10, 2018
* Feature staticssr support + escaping string (tizmagik#17) * Add static sir support * Postinstall git support * Build only * Enabled src files * Bug fix buildselector * Babel post install bug * Fixed build selector * Fix strings * Update react head * Remove build folder, leave off escape, add data-rh * Remove build
|
@oyeanuj We used a proprietary approach as this can be a fairly complex beast depending on what you want to achieve. You may want to decide to do this synchronously (blocking) and use secondary thread to deal with you dynamic content and render order respectively. Happy to comment on a more detailed issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @jamesjjk for kicking off this work in #17
fixes #14
fixes #13