Xelah #25
Draft
Xelah #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `npm i -save epitelete-html` - `npm i -save @xelah/type-perf-html --legacy-peer-deps` - `npm install --save @mui/material @mui/styles @mui/icons-material @mui/styled-engine@npm:@mui/styled-engine-sc@latest styled-components@5 --legacy-peer-deps` - `npm i -D proskomma --legacy-peer-deps` - `npm i proskomma-react-hooks --legacy-peer-deps`
|
@irahopkinson With the summit coming up tomorrow, I don't think I have time to evaluate this code very deeply, unfortunately. From a very quick glance over the code, it looks like it would be all right, but I sadly don't have experience with Xelah to help me to know what might be a red flag for that library specifically. Maybe you could ask someone in the OCE who regularly uses Xelah to quickly check for any red flags? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.