support tencent cfs csi driver default config #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmhl
reviewed
Mar 25, 2020
pkg/config/config.go
Outdated
| } | ||
|
|
||
| // AddFlags add the TencentCloud configurations to global flag. | ||
| func (c *TencentCloudConfig) AddFlags() { | ||
| flag.StringVar(&c.SecretID, "tencent-cloud-secret-id", "admin", "API Secret ID of Tencent Cloud") | ||
| flag.StringVar(&c.SecretKey, "tencent-cloud-secret-key", "admin", "API Secret Key of Tencent Cloud") | ||
| flag.StringVar(&c.VpcID, "tencent-cloud-cfs-vpc-id", "vpc-xxxxxxxx", "VpcID used in TencentCloud CFS storage") |
There was a problem hiding this comment.
We also need to config these options for csi-operator in tke.
mlmhl
reviewed
Mar 25, 2020
| @@ -20,7 +20,6 @@ package enhancer | |||
| import ( | |||
| "encoding/base64" | |||
| "fmt" | |||
|
|
|||
There was a problem hiding this comment.
No need to delete this line.
mlmhl
reviewed
Mar 25, 2020
| subnetID = e.config.SubnetID | ||
| } | ||
|
|
||
| if len(secretID) > 0 && len(secretKey) > 0 && len(subnetID) > 0 && len(vpcID) > 0 { |
There was a problem hiding this comment.
subnetID and vpcID are not necessary parameters for CBS.
wangao1236
force-pushed
the
jasonawang-cfs-support
branch
from
382509f
to
b6b8a23
Compare
wangao1236
force-pushed
the
jasonawang-cfs-support
branch
from
b6b8a23
to
1605a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.