feat: use mpc-signing-kit instead of tss-client #8
Conversation
|
| @@ -1,6 +1,15 @@ | |||
| { | |||
| "object": { | |||
| "pins": [ | |||
| { | |||
| "package": "AnyCodable", | |||
There was a problem hiding this comment.
This dependency should not be needed here.
| @@ -12,20 +21,38 @@ | |||
| }, | |||
| { | |||
| "package": "CryptoSwift", | |||
| "repositoryURL": "https://github.com/krzyzanowskim/CryptoSwift.git", | |||
| "repositoryURL": "https://github.com/krzyzanowskim/CryptoSwift", | |||
There was a problem hiding this comment.
This package cannot be included, it has to be removed.
| } | ||
| }, | ||
| { | ||
| "package": "swift-system", |
There was a problem hiding this comment.
Many of the rest of these dependencies should not be included here.
| @@ -5,27 +5,39 @@ import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "Web3SwiftMpcProvider", | |||
| platforms: [.iOS(.v13), .macOS(.v11)], | |||
| platforms: [.iOS(.v14), .macOS(.v11)], | |||
There was a problem hiding this comment.
What is needed in v14?
| .library( | ||
| name: "Web3SwiftMpcProvider", | ||
| targets: ["Web3SwiftMpcProvider"]), | ||
| name: "MPCEthereumProvider", | ||
| targets: ["MPCEthereumProvider"]), | ||
| .library( | ||
| name: "MPCBitcoinProvider", | ||
| targets: ["MPCBitcoinProvider"]), |
There was a problem hiding this comment.
This will have to be condensed into single export for cocoapods
| } | ||
|
|
||
| public func schnorrSign(message: Data, publicKey: Data) -> Data { | ||
| return Data() |
There was a problem hiding this comment.
We'd need to implement this.
There was a problem hiding this comment.
not until frost is implemented in rust
| @@ -0,0 +1,172 @@ | |||
| import BigInt | |||
| import Foundation | |||
| import curveSecp256k1 | |||
There was a problem hiding this comment.
For this import you'll need a canImport() macro.
| import curveSecp256k1 | ||
| import web3 | ||
| import mpc_core_kit_swift | ||
|
|
There was a problem hiding this comment.
Why dump all the classes, enums, etc in the same file over logical seperation?
| extension MpcCoreKit : EthereumAccountProtocol { | ||
| public var address: web3.EthereumAddress { | ||
| // try async | ||
| return EthereumAddress(KeyUtil.generateAddress(from: self.getTssPubKey().suffix(64) ).toChecksumAddress()) |
There was a problem hiding this comment.
Hmm. I remmeber self.getTssPubKey being both async and throwable, if I remember correctly it needs to remain so. What changed here?
| @@ -1,6 +1,6 @@ | |||
| import BigInt | |||
| import web3 | |||
| import Web3SwiftMpcProvider | |||
| import MPCEthereumProvider | |||
| import XCTest | |||
|
|
|||
| final class Web3SwiftMpcProviderTests: XCTestCase { | |||
There was a problem hiding this comment.
Why have you disabled all the tests?
No description provided.