Search system DLLs for hooking via VADs (not via PEB) #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@drakvuf-jenkins Test this please |
|
@drakvuf-jenkins Test this please |
disaykin
reviewed
Sep 5, 2023
| hook_dll(drakvuf, info, &ctx->mmvad.value(), &ctx->is_hooked); | ||
| } | ||
|
|
||
| bool get_module_mmvad(drakvuf_t drakvuf, addr_t eprocess, addr_t base_address, mmvad_info_t* mmvad) |
There was a problem hiding this comment.
More clean would be use std::optional:
std::optional<mmvad_info_t> get_module_mmvad(drakvuf_t drakvuf, addr_t eprocess, addr_t base_address);
disaykin
reviewed
Sep 5, 2023
| if (!mmvad->file_name_ptr) | ||
| return false; | ||
|
|
||
| if (drakvuf_mmvad_type(drakvuf, mmvad) != 2) // VAD_TYPE_DLL |
There was a problem hiding this comment.
Using the VAD_TYPE_DLL constant will eliminate the need to add comments
disaykin
reviewed
Sep 5, 2023
|
|
||
| auto* vctx = (visitor_context_t*)callback_data; | ||
|
|
||
| if (name.find(vctx->name) != std::string::npos) |
There was a problem hiding this comment.
This comparison is not perfect:
name = "msi.dllhack.dll"
vctx->name = "msi.dll"
and
name = "not_a_ntdll.dll"
vctx->name = "ntdll.dll"
would be true
There was a problem hiding this comment.
Please open an issue for this to be tracked as the PR has been merged
There was a problem hiding this comment.
The new code is logically identical to the old one:
if (name.find("ntdll.dll") != std::string::npos)
so the note is about the refactoring and not this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, an unreliable algorithm for searching for system DLLs through PEB has been implemented, for at least three reasons:
The patch implements traverse via VADs.
Also fixed a bug where, after a failed hook attempt, the process is still added to the cache (this is now controlled by the
is_hookedflag).