Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libinjector: skip kernel mode trap frame and split wait_for_target_process_cb #1706

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

psrok1
Copy link
Contributor

@psrok1 psrok1 commented Sep 13, 2023

Following the discussion from #1639

  • Splitted part of wait_for_target_process_cb into setup_usermode_trap_x86 and setup_usermode_trap_x64 to reduce cognitive complexity within that function
  • Fixed bug in setup_usermode_trap_x64 that catched kernel-mode address from trap frame. It was rare case and probably related to page fault inside kernel.
  • Added description to setup_usermode_trap_x86 explaining why we need to use different methods on x64 and x86.

@drakvuf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@tklengyel
Copy link
Owner

@drakvuf-jenkins Test this please

@tklengyel tklengyel merged commit b38d7ed into tklengyel:main Sep 13, 2023
41 checks passed
@tklengyel
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants