Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tty support for darwin (#15) #15

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: tty support for darwin (#15) #15

merged 1 commit into from
Oct 29, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Oct 29, 2024

This pull request fixes the tty support for MacOS by using the corresponding golang extension. Besides, it extends the config interface allowing to add default set up functions in the default constructor instead of chaining it.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9a06507) 486 486 100.00%
Head commit (d4a88b3) 487 (+1) 487 (+1) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tkrop tkrop merged commit 028225d into main Oct 29, 2024
5 of 7 checks passed
@tkrop tkrop deleted the tty-support branch October 29, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant