Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zerolog support (#16) #16

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat: add zerolog support (#16) #16

merged 1 commit into from
Nov 6, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Nov 6, 2024

This pull request adds support for zerolog, fixes bugs, and improve interface. However, it should be noted that zerolog is only advantageous, if it logs binary (CBOR) or creates native JSON output. If the pretty printing is enabled, zerolog creates many additional conversions that brings it at least down to the level of logrus.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (028225d) 487 487 100.00%
Head commit (fd08b36) 635 (+148) 635 (+148) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16) 250 250 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tkrop tkrop merged commit a8ca715 into main Nov 6, 2024
7 checks passed
@tkrop tkrop deleted the zerolog-support branch November 6, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant