Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up and improve (#8) #8

Merged
merged 1 commit into from
Sep 22, 2024
Merged

feat: clean up and improve (#8) #8

merged 1 commit into from
Sep 22, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Sep 22, 2024

This pull request cleans up the code, especially with respect to error handling, fixes some minor bugs, and improves the test code.

@tkrop tkrop added bug Something isn't working enhancement New feature or request labels Sep 22, 2024
@tkrop tkrop self-assigned this Sep 22, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8e48841) 319 319 100.00%
Head commit (95222b3) 338 (+19) 338 (+19) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#8) 41 41 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tkrop tkrop merged commit 9eead42 into main Sep 22, 2024
5 of 7 checks passed
@tkrop tkrop deleted the cleanup branch September 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant