Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race on exit error (#87) #87

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: data race on exit error (#87) #87

merged 1 commit into from
Sep 23, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Sep 23, 2024

This pull request fixes a data race in the main test pattern on the exit error instance that was shared by making it test internal.

@tkrop tkrop added the bug Something isn't working label Sep 23, 2024
@tkrop tkrop self-assigned this Sep 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10989155004

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.841%
Totals Coverage Status
Change from base Build 10981301230: 0.0%
Covered Lines: 1880
Relevant Lines: 1883
💛 - Coveralls

@tkrop tkrop merged commit e440d42 into main Sep 23, 2024
7 checks passed
@tkrop tkrop deleted the data-race branch September 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkrop tkrop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkrop @coveralls