Fixes #243 - Add initial kustomize templates for this project #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqian
reviewed
Jul 15, 2022
zqian
reviewed
Jul 15, 2022
zqian
reviewed
Jul 15, 2022
jonespm
commented
Jul 15, 2022
Updating some hostnames Switching secrets to secret
ssciolla
reviewed
Jul 22, 2022
| @@ -0,0 +1,11 @@ | |||
| - op: replace | |||
| path: /spec/template/spec/containers/0/image | |||
| value: docker-registry.default.svc:5000/canvas-app-explorer-test/canvas-app-explorer:latest | |||
There was a problem hiding this comment.
Would be nice to parameterize this if we plan to run this on all releases.
There was a problem hiding this comment.
Or maybe it makes more sense to just update the value with the release tag on each release. I'm not sure.
ssciolla
reviewed
Jul 26, 2022
ssciolla
reviewed
Jul 26, 2022
| @@ -0,0 +1,11 @@ | |||
| - op: replace | |||
| path: /spec/template/spec/containers/0/image | |||
| value: docker-registry.default.svc:5000/canvas-app-explorer-test/canvas-app-explorer:latest | |||
There was a problem hiding this comment.
Or maybe it makes more sense to just update the value with the release tag on each release. I'm not sure.
ssciolla
reviewed
Jul 31, 2022
Comment on lines
+7
to
+8
| bases: | ||
| - ../../base |
There was a problem hiding this comment.
I'm not exactly sure how this would be done (since I don't know the kustomize YAML syntax well), but we probably want to omit the build config inherited from base in this overlay.
Comment on lines
+1
to
+4
| # OpenShift configuration with Kustomize | ||
|
|
||
| Resource configuration and secret consumption for OpenShift projects are managed | ||
| using [`kustomize`](https://kubectl.docs.kubernetes.io/guides/introduction/kustomize/). |
There was a problem hiding this comment.
We could link to this file from the main README.
Co-authored-by: Sam Sciolla <[email protected]>
Co-authored-by: Sam Sciolla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft. A few things I'd like to figure out