Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I349 react upgrade #358

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

pushyamig
Copy link
Contributor

@pushyamig pushyamig commented Nov 15, 2024

I have updated to most of the package to recent except of couple

@tanstack/react-query: This version latest is version 5 and it has some change which need adding UseEffect which I want to avoid, but instead I upgraded to V4 that itself had major changes. The repo Owner changed npm package. V5 will be addressed in next release
https://tanstack.com/query/v4/docs/framework/react/guides/migrating-to-react-query-4

ESLint and its supported packages are one version behind the latest release. I chose not to update this since Eslint V9 has breaking changes eslintrc.js (eslint configuration) is changed to [eslint.config.js ] (https://eslint.org/docs/latest/use/configure/configuration-files) and the way it is configured within. So felt we can wait.
https://eslint.org/version-support/

Material UI is V6, opted to stay on V5. Since most of our app still on V5

Use the cli command to check what is latest

  1. ncu
  2. npm show eslint@8 version

Testplan:

  1. Do a docker clean and start the tool.
  2. Make sure the Get/PUT function while adding and removing the tool works. Since all those API call from FE is handled by this @tanstack/react-query upgrade
  3. Make sure No linting errors in the VSCode.

@pushyamig
Copy link
Contributor Author

@zqian and @jonespm this PR needs a Review with FE dependency update

@jonespm jonespm linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Member

@jonespm jonespm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts up fine. Looks good after quick tests.

@pushyamig
Copy link
Contributor Author

Thanks @jonespm for the review, I will merge it now

@pushyamig pushyamig merged commit 4543361 into tl-its-umich-edu:main Nov 19, 2024
pushyamig added a commit to pushyamig/canvas-app-explorer that referenced this pull request Nov 25, 2024
* Upgrading to react typscript, react-query and other package to the next to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade React 18
2 participants