Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix key error in binary data #176

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: fix key error in binary data #176

merged 2 commits into from
Sep 28, 2023

Conversation

tlambert03
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #176 (16222f6) into main (6260200) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          17       17           
  Lines        2327     2328    +1     
=======================================
+ Hits         2213     2214    +1     
  Misses        114      114           
Files Coverage Δ
src/nd2/readers/_modern/modern_reader.py 93.31% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2023

CodSpeed Performance Report

Merging #176 will not alter performance

Comparing fix-binary (16222f6) with main (6260200)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 merged commit 063da7c into main Sep 28, 2023
17 checks passed
@tlambert03 tlambert03 deleted the fix-binary branch September 28, 2023 23:21
@tlambert03 tlambert03 added the bug Something isn't working label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant