Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix extraction of xy points in extruded shapes #183

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

tlambert03
Copy link
Owner

fixes #182

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2023

CodSpeed Performance Report

Merging #183 will not alter performance

Comparing fix-extruded (68f0fc1) with main (82e7005)

Summary

✅ 13 untouched benchmarks

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #183 (68f0fc1) into main (82e7005) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          17       17           
  Lines        2338     2338           
=======================================
  Hits         2229     2229           
  Misses        109      109           
Files Coverage Δ
src/nd2/structures.py 96.08% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit 2fe31e0 into main Oct 10, 2023
18 checks passed
@tlambert03 tlambert03 deleted the fix-extruded branch October 10, 2023 12:39
@tlambert03 tlambert03 added the bug Something isn't working label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates for RoiShapeType.Polygon not showing
1 participant