Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix aicsimageio test #188

Merged
merged 1 commit into from
Nov 13, 2023
Merged

test: fix aicsimageio test #188

merged 1 commit into from
Nov 13, 2023

Conversation

tlambert03
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #188 (d98f7d5) into main (ba78c7a) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   95.35%   95.40%   +0.04%     
==========================================
  Files          17       17              
  Lines        2348     2348              
==========================================
+ Hits         2239     2240       +1     
+ Misses        109      108       -1     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@tlambert03 tlambert03 merged commit 4eeea50 into main Nov 13, 2023
17 of 18 checks passed
@tlambert03 tlambert03 deleted the fix-test branch November 13, 2023 18:31
Copy link

codspeed-hq bot commented Nov 13, 2023

CodSpeed Performance Report

Merging #188 will degrade performances by 20.81%

Comparing fix-test (d98f7d5) with main (ba78c7a)

Summary

❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-test Change
test_time_imread_dask[train_TR67_Inj7_fr50] 580.3 ms 732.8 ms -20.81%
test_time_imread_dask[karl_sample_image] 2.1 s 2.6 s -18.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant