Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hacky fix for files with subloops #193

Merged
merged 4 commits into from
Feb 22, 2024
Merged

fix: hacky fix for files with subloops #193

merged 4 commits into from
Feb 22, 2024

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Nov 15, 2023

This is a proof-of-principle hacky fix for the file that @aaristov shared in #190

@aaristov, if you're inclined, feel free to check out this branch and see if it works for you. I won't be merging this until I understand a bit better how that file ended up with this structure.

closes #190

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8b2fd66) 95.49% compared to head (837b356) 95.16%.

Files Patch % Lines
src/nd2/_parse/_parse.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   95.49%   95.16%   -0.33%     
==========================================
  Files          17       17              
  Lines        2308     2318      +10     
==========================================
+ Hits         2204     2206       +2     
- Misses        104      112       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 15, 2023

CodSpeed Performance Report

Merging #193 will not alter performance

Comparing subloops (837b356) with main (8b2fd66)

Summary

✅ 13 untouched benchmarks

@aaristov
Copy link

Hi Talley,

Just to let you know that you did a fantastic job and this branch works really well with the paused acquisitions, so I'd be happy to see it merged into production. Let me know if you need something before this happens.

Best
Andrey

@tlambert03
Copy link
Owner Author

Thanks @aaristov. I did end up getting some feedback from the folks at Laboratory Imaging, so I have a bit more info now on how to "properly" handle this unusual case. But, that proper way is even more convoluted 😂 hence my delay. But, if this is better than nothing, and you'd like to see it in, perhaps I'll just cut a release with this version, and then make more robust in a follow up.

@tlambert03 tlambert03 marked this pull request as ready for review February 21, 2024 21:53
@tlambert03 tlambert03 enabled auto-merge (squash) February 21, 2024 21:57
@tlambert03 tlambert03 merged commit 9324428 into main Feb 22, 2024
21 of 23 checks passed
@tlambert03 tlambert03 deleted the subloops branch February 22, 2024 01:16
@tlambert03 tlambert03 added the bug Something isn't working label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing axis
2 participants