Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop aicsimageio test #227

Merged
merged 2 commits into from
Apr 22, 2024
Merged

test: drop aicsimageio test #227

merged 2 commits into from
Apr 22, 2024

Conversation

tlambert03
Copy link
Owner

the aicsimageio tests fail more often than others, for issues unrelated to nd2. it's in maintenance mode so testing here is probable unnecessary

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (c1848a3) to head (bd0f165).

❗ Current head bd0f165 differs from pull request most recent head cb18983. Consider uploading reports for the commit cb18983 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   95.27%   94.98%   -0.29%     
==========================================
  Files          18       18              
  Lines        2433     2433              
==========================================
- Hits         2318     2311       -7     
- Misses        115      122       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title drop aicsimageio test test: drop aicsimageio test Apr 22, 2024
@tlambert03 tlambert03 enabled auto-merge (squash) April 22, 2024 17:15
@tlambert03 tlambert03 added the tests Tests & CI label Apr 22, 2024
@tlambert03 tlambert03 merged commit f139810 into main Apr 22, 2024
19 checks passed
@tlambert03 tlambert03 deleted the drop-aicsimageio-test branch April 22, 2024 17:16
Copy link

codspeed-hq bot commented Apr 22, 2024

CodSpeed Performance Report

Merging #227 will not alter performance

Comparing drop-aicsimageio-test (cb18983) with main (c1848a3)

Summary

✅ 13 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests & CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant