-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modulo[wip] #222
base: main
Are you sure you want to change the base?
feat: modulo[wip] #222
Conversation
CodSpeed Performance ReportMerging #222 will not alter performanceComparing Summary
|
This is great, thanks, @tlambert03! As I mentioned on Zulip, https://github.com/ome/bioformats/blob/bc1fcddd5329d900853d55c6f8378e9235a26a53/components/formats-api/src/loci/formats/Modulo.java#L39 is probably the best definition of truth for the moment. But if you have any other questions, @jburel, @dgault, @sbesson, and @melissalinkert can hopefully help us out. |
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 86.75% 79.55% -7.20%
==========================================
Files 24 25 +1
Lines 1200 1252 +52
==========================================
- Hits 1041 996 -45
- Misses 159 256 +97 ☔ View full report in Codecov by Sentry. |
@joshmoore, here's the beginning of a modulo type
as you can see, the namespaces are still a bit messed up... but it's a start