-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Decoding done with iconv-lite, support for all idv3 text encoding types #4
base: master
Are you sure you want to change the base?
Conversation
…bundling, idv3v1 deserialized as id3v2 object. UPDATE: preparing for frames object serialization by preserving frame flags, unknown frame content.
I'm not opposed in theory to either adding more support for encoding or adding more ID3v2 tags. However, there are a few goals that this library aims for:
1 means there can be no external dependencies (and also because this needs to run in the browser). Also, there are a lot of ID3v2 tags that can be supported; I don't necessarily want this library to handle all of them (due to the file size issue). By default it handles the most common ones, which I think is enough. Things like So in order for me to accept this pull request, you would need to do the following:
If you think that's stupid, I understand. This library has very specific goals that I want to adhere to that may not be in line with what you need. If you want to keep your fork with more robust tag parsing, let me know where you put it and I will be happy to put a link to it in the README. |
No description provided.