Have removed all explicit class constraints and nothing blows up #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the unit tests still pass, however I have not added anything to them as there are loads of them and I don't want to go down the rabbit hole of verifying all same tests but with structs, also didn't run integration tests. However it's a start incase anyone else wants to pick it up.
|
I'm validating the test execution in this PR. It will be merged soon if its ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the unit tests still pass, however I have not added anything to them as there are loads of them and I don't want to go down the rabbit hole of verifying all same tests but with structs, also didn't run integration tests.
However it's a start incase anyone else wants to pick it up.
#294