Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InnerXml #53

Closed
wants to merge 1 commit into from
Closed

Conversation

justkawal
Copy link

@justkawal justkawal commented Jan 4, 2024

Because the way you organised the code, It became very easy to give InnerXml functionality.
I've never felt this easy to add a feature to any library before.

If by any chance I have missed something which might be cause trouble in the future. Would be all ears to know.

Thanks again for your time and this awesome contribution.

@tnc1997
Copy link
Owner

tnc1997 commented Jan 4, 2024

Hi @justkawal, thank you very much for your contribution!

I was wondering if you saw my reply to the associated feature request?

I think that we could probably cover the functionality in that feature request as part of the work in progress support for custom converters.

I would be keener to use custom converters for this use case because InnerXml isn't really a type of XmlNode like XmlAttribute and XmlElement.

@justkawal justkawal closed this Jan 4, 2024
@justkawal
Copy link
Author

Hi @justkawal, thank you very much for your contribution!

I was wondering if you saw my reply to the associated feature request?

I think that we could probably cover the functionality in that feature request as part of the work in progress support for custom converters.

I would be keener to use custom converters for this use case because InnerXml isn't really a type of XmlNode like XmlAttribute and XmlElement.

I would be waiting for that feature....
It would be very useful for me....

Any rough expected Idea by when we could have that ready?

@tnc1997
Copy link
Owner

tnc1997 commented Jan 5, 2024

Any rough expected Idea by when we could have that ready?

I currently have a work in progress branch and I am hoping to have it ready to merge within the next couple of weeks.

@justkawal justkawal deleted the origin/justkawal/innerxml branch November 8, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants