alarm: remove references to timezone #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of timezone in `{get/set}timeofday` is deprecated.
If something did try to pass us the parameter, our implementation would
(incorrectly) ignore it. More significantly, our implementation does not
check that the `timeval` struct is nonnull before dereferencing it.
This updates libtock's interface to match our implementation and the
common-case scenario, and leaves the question of what to do if something
tries to use the legacy `tz` parameter to whomever implements the
wrapper.
alistair23
approved these changes
Oct 30, 2024
bradjc
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of timezone in
{get/set}timeofdayis deprecated.If something did try to pass us the parameter, our implementation would (incorrectly) ignore it. More significantly, our implementation does not check that the
timevalstruct is nonnull before dereferencing it.This updates libtock's interface to match our implementation and the common-case scenario, and leaves the question of what to do if something tries to use the legacy
tzparameter to whomever implements the wrapper.