Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): real nested list on html export #8511

Merged

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Oct 14, 2024

This closes BS-125, closes #6252, possibly closes #8126.
This PR also fixes a bug in markdown when encountering continuous lists with different type.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 5a51bfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 2:54am

Copy link

graphite-app bot commented Oct 14, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fourdim commented Oct 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fourdim and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Oct 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5a51bfb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fourdim fourdim marked this pull request as ready for review October 14, 2024 04:47
@fourdim fourdim requested a review from a team as a code owner October 14, 2024 04:47
Copy link
Contributor

github-actions bot commented Oct 14, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.06 MB (-0.03% 🔽)
@blocksuite/affine/block-std 154.54 KB (0%)
@blocksuite/affine/block-std/gfx 77.48 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 210 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.58 KB (+0.06% 🔺)
@blocksuite/affine/inline 32.11 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.86 MB (+0.02% 🔺)
@blocksuite/affine/blocks 1.95 MB (-0.05% 🔽)
@blocksuite/affine/blocks/schemas 87.75 KB (0%)

@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 6b0dda6 to 55a9903 Compare October 14, 2024 04:49
@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 55a9903 to 41e7d56 Compare October 14, 2024 05:08
@fourdim fourdim marked this pull request as draft October 14, 2024 05:18
@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 41e7d56 to 15b3583 Compare October 15, 2024 01:50
@fourdim fourdim marked this pull request as ready for review October 15, 2024 01:51
@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 15b3583 to 0024562 Compare October 15, 2024 02:01
@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 0024562 to 9702fd7 Compare October 15, 2024 02:09
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fourdim fourdim added the merge label Oct 15, 2024
Copy link
Contributor Author

fourdim commented Oct 15, 2024

Merge activity

  • Oct 14, 10:35 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 14, 10:35 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 14, 10:57 PM EDT: A user merged this pull request with the Graphite merge queue.

This closes [BS-125](https://linear.app/affine-design/issue/BS-125), closes #6252, possibly closes #8126.
This PR also fixes a bug in markdown when encountering continuous lists with different type.
@fourdim fourdim force-pushed the 10-14-fix_blocks_real_nested_list_on_html_export branch from 9702fd7 to 5a51bfb Compare October 15, 2024 02:52
@graphite-app graphite-app bot merged commit 5a51bfb into master Oct 15, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 10-14-fix_blocks_real_nested_list_on_html_export branch October 15, 2024 02:57
donteatfriedrice added a commit that referenced this pull request Oct 16, 2024
## Features:

[feat: markdown adapter with latex](#8503)

[feat: support notion block equation html import](#8504)

[feat: support edgeless tidy up](#8516)

[feat: support notion callout block to blocksuite quote block](#8523)

[feat(playground): add import notion zip entry](#8527)

## Bugfix:

[fix(blocks): auto focus latex block](#8505)

[fix: enhance button layout with icon alignment](#8508)

[fix(edgeless): ime will crash edgeless text width](#8506)

[fix(edgeless): edgeless text is deleted when first block is empty](#8512)

[fix: notion html quote block import](#8515)

[fix: yjs warning](#8519)

[fix(blocks): real nested list on html export](#8511)

[fix(edgeless): cmd a will select element inner frame](#8517)

[fix(edgeless): disable contenteditable when edgeless text not in editing state](#8525)

[fix: import notion toggle list as toggle bulleted list](#8528)

## Refactor:

[refactor(database): signals version datasource api](#8513)

[refactor(edgeless): element tree manager](#8239)

[refactor(blocks): simplify frame manager implementation](#8507)

[refactor: update group test utils using container interface](#8518)

[refactor: update frame test with container test uitls](#8520)

[refactor(database): context-menu ui and ux](#8467)

[refactor: move chat block to affine](#8420)

## Misc

[perf: optimize snapshot job handling](#8428)

[perf(edgeless): disable shape shadow blur](#8532)

[chore: bump up all non-major dependencies](#8514)

[chore: Lock file maintenance](#8510)

## Docs

[docs: fix table structure warning](#8509)

[docs: edgeless data structure desc](#8531)

[docs: update link](#8533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants