Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert built-in component to widget #8577

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

doouding
Copy link
Member

@doouding doouding commented Oct 22, 2024

Changed

Refactor those built-in component into widget:

  • edgeless-selected-rect
  • edgeless-dragging-area-rect
  • edgeless-navigator-black-background
  • edgeless-toolbar
  • note-slicer

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: b17901e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 3:22am

Copy link

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

doouding commented Oct 22, 2024

Copy link

nx-cloud bot commented Oct 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b17901e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@L-Sun L-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link

graphite-app bot commented Oct 24, 2024

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/8577 to master October 24, 2024 03:19
### Changed

Refactor those built-in component into widget:

- edgeless-selected-rect
- edgeless-dragging-area-rect
- edgeless-navigator-black-background
- edgeless-toolbar
- note-slicer
Copy link
Contributor

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.06 MB (-0.05% 🔽)
@blocksuite/affine/block-std 156.97 KB (0%)
@blocksuite/affine/block-std/gfx 80.1 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.83 KB (0%)
@blocksuite/affine/global/env 210 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.54 KB (0%)
@blocksuite/affine/inline 32.03 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.87 MB (+0.5% 🔺)
@blocksuite/affine/blocks 1.96 MB (+0.53% 🔺)
@blocksuite/affine/blocks/schemas 88.66 KB (0%)

@graphite-app graphite-app bot merged commit b17901e into master Oct 24, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 10-22-refactor_built-in_component_to_widget branch October 24, 2024 03:25
@doouding doouding mentioned this pull request Oct 24, 2024
doouding added a commit that referenced this pull request Oct 24, 2024
## Feat
- feat(blocks): add more html transformer apis (#8573)
- feat(blocks): support more markdown transformer api (#8564)
- feat(blocks): add abort controller to peekviewservice (#8558)
- feat: add docLinkMiddleware for linked doc export (#8553)
## Fix
- fix: mind map dragging issue (#8563)
- fix(database): can't use horizontal scrollbar (#8576)
- fix: note width is less than minimum width after resize and arrange (#8550)
- fix: newly created note alignments cannot be stored persistently (#8551)
- fix: inline range calculation not expected (#8552)
- fix(database): avoid filter bar flickering (#8562)
- fix(database): drag and drop block into database block (#8561)
- fix(blocks): split paragraphs based on newlines (#8556)
- fix(database): incorrect delete row logic (#8544)
- fix: note height less than minimum height (#8542)
## Chore
- chore: add changelog generating script (#8582)
- chore: optimize zip transformer api (#8580)
- chore: adjust attachment click events, like image, to support opening in peek view (#8579)
- chore: remove useless import (#8571)
## Refactor
- refactor: convert built-in component to widget (#8577)
- refactor: migrating legacy tools (#8471)
- refactor: edgeless tool manager (#8438)
- refactor(playground): organize export and import menu items into submenus in the debug menu (#8557)
- refactor: combine unsafeCSS and cssVar (#8545)
## Perf
- perf(edgeless): use css var to place collaboration cursors-n-selections on board zoom change (#8543)
This was referenced Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants