Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error output for clarity, update docs for tofuenv use #14

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

anastasiiakozlova245
Copy link
Contributor

@anastasiiakozlova245 anastasiiakozlova245 commented Dec 30, 2023

Updated logging for tofuenv use and install commands, updated readme.

Before:

  • run tofuenv use without arguments
  • Output:
    No versions matching 'latest:^[0-9]\+\.[0-9]\+\.[0-9]\+$' found in remote

After:

  • run tofuenv use without arguments
  • Output:
    No latest versions matching '^[0-9]\+\.[0-9]\+\.[0-9]\+$' found in remote

This change improves clarity about the exact regex used to search and excludes confusion that might be caused by the previous error description.

Tests:
tofuenv use latest:2.10
No latest versions matching '2.10' found in remote
tofuenv use 2.1.0
No 2.1.0 versions matching '^2.1.0$' found in remote
tofuenv use latest:^0.8
No latest versions matching '^0.8' found in remote

Nmishin
Nmishin previously approved these changes Dec 30, 2023
@kvendingoldo
Copy link
Contributor

lgtm

kvendingoldo
kvendingoldo previously approved these changes Dec 31, 2023
kvendingoldo
kvendingoldo previously approved these changes Jan 2, 2024
@anastasiiakozlova245 anastasiiakozlova245 merged commit 847e0a7 into main Jan 2, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants